Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdks): support tsserver inter-process communication #3991

Merged
merged 1 commit into from
Jan 17, 2022
Merged

fix(sdks): support tsserver inter-process communication #3991

merged 1 commit into from
Jan 17, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jan 17, 2022

What's the problem this PR addresses?

TypeScript 4.6 and VSCode 1.64 will start using inter-process communication which the SDK doesn't handle and crashes.

How did you fix it?

Update the SDK to handle object messages

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz changed the title fix(sdks): support typescript IPC fix(sdks): support tsserver inter-process communication Jan 17, 2022
@arcanis arcanis merged commit fbd20be into master Jan 17, 2022
@arcanis arcanis deleted the merceyz/fix/sdk-ts-ipc branch January 17, 2022 12:40
arcanis pushed a commit that referenced this pull request Jan 18, 2022
@merceyz @arcanis
fix(sdks): support typescript IPC (#3991)
533014f
@julienfouilhe julienfouilhe mentioned this pull request Feb 1, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merceyz @arcanis