Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames pnpEnableExperimentalEsm into pnpEnableEsmLoader #3635

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Oct 25, 2021

What's the problem this PR addresses?

Using experimental in the name isn't necessary since the setting is enabled by default (so only a segment of those who use it will see the warning), and would require either a compatibility check or users to edit their configuration once we graduate the feature. Note that It'll still be experimental, as explained in the documentation.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit fe834db into master Oct 25, 2021
@arcanis arcanis deleted the mael/esm-setting-name branch October 25, 2021 13:54
@shuding
Copy link

shuding commented Jan 29, 2022

The default is still false here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants