-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pnp)!: remove fallbacks to react-scripts
and gatsby
#3004
Draft
merceyz
wants to merge
2
commits into
master
Choose a base branch
from
merceyz/chore/compat-fallback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
3 times, most recently
from
June 8, 2021 18:45
7883c19
to
f186186
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
August 28, 2021 10:05
f186186
to
4e4a0aa
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
3 times, most recently
from
September 12, 2021 22:20
d428d48
to
16b046a
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
November 25, 2021 15:36
16b046a
to
5b50c2f
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
January 5, 2022 12:23
5b50c2f
to
6fc471a
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
January 24, 2022 15:19
6fc471a
to
5ac7808
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
March 13, 2022 19:05
5ac7808
to
42c39c7
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
March 30, 2022 08:48
42c39c7
to
a7fd51a
Compare
This was referenced Mar 30, 2022
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
2 times, most recently
from
April 2, 2022 13:02
59e173d
to
7b68072
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
April 26, 2022 20:14
7b68072
to
77fa3d2
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
July 10, 2022 11:03
77fa3d2
to
406aca9
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
July 25, 2022 13:15
406aca9
to
6a2e17d
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
August 8, 2022 01:00
5c410a9
to
ccc99ee
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
September 2, 2022 17:02
ccc99ee
to
f50870a
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
September 28, 2022 15:39
f50870a
to
2e977e3
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
October 30, 2022 12:44
2e977e3
to
e75dbb2
Compare
2 tasks
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
November 27, 2022 12:54
e75dbb2
to
f48e7c9
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
December 12, 2022 18:07
f48e7c9
to
3338a0a
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
June 18, 2023 19:43
3338a0a
to
3653c84
Compare
merceyz
force-pushed
the
merceyz/chore/compat-fallback
branch
from
November 4, 2023 13:43
3653c84
to
dea6cc7
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The PnP API has a compatibility feature that allows dependencies to access the dependencies of
react-scripts
andgatsby
but these fallbacks cause hard to debug issues and hides undeclared dependencies.How did you fix it?
Removed the fallbacks
Checklist