Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ember-cli 2.13 / Babel6 / yarn #94

Merged
merged 1 commit into from
Jun 11, 2017

Conversation

simonihmig
Copy link
Contributor

This should fix as well the currently failing tests for recent Ember versions (currently release, beta etc. were all failing):

  • I skipped the tests checking for throwing an exception, because they did not work anymore with newer Ember versions. Did not dig into it, but seems the exception is thrown async (other run loop?), so assert.throws did not catch them
  • I also skipped the test I once wrote documenting the still present issue [Glimmer2] DOMException with {{#if}} helper #66. As this limitation is now documented in the Readme, and no quick fix seems possible, I assumed it would be more appropriate to skip this for now than to having failing builds everywhere...

I will come up with another PR addressing #77, so don't release this yet as is... :)

@lukemelia
Copy link
Contributor

Looks excellent, @simonihmig! Thanks for working on this. One small change request. Can you remove .idea/watcherTasks.xml from the PR?

@simonihmig
Copy link
Contributor Author

Can you remove .idea/watcherTasks.xml from the PR?

@lukemelia Oups, good that you catched this one! Just removed this.

@lukemelia lukemelia merged commit 148853e into yapplabs:master Jun 11, 2017
@simonihmig simonihmig deleted the upgrade-ember-cli branch September 9, 2017 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants