Respect MODAL_DIALOG_USE_TETHER application property #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislopresto
force-pushed
the
improve-testing
branch
3 times, most recently
from
db364cf
to
5ce019e
Compare
This provides a mechanism to override the auto detection of ember-tether. The primary use case for this is to allow ember-modal-dialog's acceptance tests to test with and without tether. We are adding a dev dependency on ember-legacy-views in order to continue to support setting a view as an alignmentTarget in Ember 2.0 beta or later. If you are not using this feature, things will work fine without this dependency being present in your application.
chrislopresto
added a commit
that referenced
this pull request
Jul 27, 2015
Respect MODAL_DIALOG_USE_TETHER application property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a mechanism to override the auto detection of
ember-tether. The primary use case for this is to allow
ember-modal-dialog's acceptance tests to test with and without
tether.
We are adding a dev dependency on ember-legacy-views in order to
continue to support setting a view as an alignmentTarget in
Ember 2.0 beta or later. If you are not using this feature, things will
work fine without this dependency being present in your application.