Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing this. prefixes to the templates #329

Merged
merged 1 commit into from
May 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions addon/templates/components/basic-dialog.hbs
Original file line number Diff line number Diff line change
@@ -1,45 +1,45 @@
{{#ember-wormhole to=destinationElementId}}
{{#if isOverlaySibling}}
<div class="{{wrapperClassNamesString}} {{wrapperClass}}">
{{#if hasOverlay}}
{{#ember-wormhole to=this.destinationElementId}}
{{#if this.isOverlaySibling}}
<div class="{{this.wrapperClassNamesString}} {{this.wrapperClass}}">
{{#if this.hasOverlay}}
<div
class={{overlayClassNamesString}}
onclick={{action onClickOverlay}}
class={{this.overlayClassNamesString}}
onclick={{action this.onClickOverlay}}
tabindex="-1"
data-emd-overlay
>
</div>
{{/if}}
{{#ember-modal-dialog-positioned-container
class=containerClassNamesString
targetAttachment=targetAttachment
target=legacyTarget
class=this.containerClassNamesString
targetAttachment=this.targetAttachment
target=this.legacyTarget
}}
{{yield}}
{{/ember-modal-dialog-positioned-container}}
</div>
{{else}}
<div class="{{wrapperClassNamesString}} {{wrapperClass}}">
{{#if hasOverlay}}
<div class="{{this.wrapperClassNamesString}} {{this.wrapperClass}}">
{{#if this.hasOverlay}}
<div
class={{overlayClassNamesString}}
onclick={{action (ignore-children onClickOverlay)}}
class={{this.overlayClassNamesString}}
onclick={{action (ignore-children this.onClickOverlay)}}
tabindex="-1"
data-emd-overlay
>
{{#ember-modal-dialog-positioned-container
class=containerClassNamesString
targetAttachment=targetAttachment
target=legacyTarget
class=this.containerClassNamesString
targetAttachment=this.targetAttachment
target=this.legacyTarget
}}
{{yield}}
{{/ember-modal-dialog-positioned-container}}
</div>
{{else}}
{{#ember-modal-dialog-positioned-container
class=containerClassNamesString
targetAttachment=targetAttachment
target=legacyTarget
class=this.containerClassNamesString
targetAttachment=this.targetAttachment
target=this.legacyTarget
}}
{{yield}}
{{/ember-modal-dialog-positioned-container}}
Expand Down
2 changes: 1 addition & 1 deletion addon/templates/components/in-place-dialog.hbs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div
class={{concat containerClassNamesString " " attachmentClass " " containerClass}}
class={{concat this.containerClassNamesString " " this.attachmentClass " " this.containerClass}}
>
{{yield}}
</div>
34 changes: 17 additions & 17 deletions addon/templates/components/liquid-dialog.hbs
Original file line number Diff line number Diff line change
@@ -1,43 +1,43 @@
{{#if isOverlaySibling}}
{{#if this.isOverlaySibling}}
{{#liquid-wormhole
stack=stack
value=value
class=(concat "liquid-dialog-container " wrapperClassNamesString " " wrapperClass)
stack=this.stack
value=this.value
class=(concat "liquid-dialog-container " this.wrapperClassNamesString " " this.wrapperClass)
}}
<div class="{{wrapperClassNamesString}} {{wrapperClass}}">
{{#if hasOverlay}}
<div class="{{this.wrapperClassNamesString}} {{this.wrapperClass}}">
{{#if this.hasOverlay}}
<div
class={{overlayClassNamesString}}
onclick={{action onClickOverlay}}
class={{this.overlayClassNamesString}}
onclick={{action this.onClickOverlay}}
tabindex="-1"
data-emd-overlay
>
</div>
{{/if}}
<div class={{containerClassNamesString}}>
<div class={{this.containerClassNamesString}}>
{{yield}}
</div>
</div>
{{/liquid-wormhole}}
{{else}}
{{#liquid-wormhole
stack=stack
value=value
class=(concat "liquid-dialog-container " wrapperClassNamesString " " wrapperClass)
stack=this.stack
value=this.value
class=(concat "liquid-dialog-container " this.wrapperClassNamesString " " this.wrapperClass)
}}
{{#if hasOverlay}}
{{#if this.hasOverlay}}
<div
class={{overlayClassNamesString}}
onclick={{action (ignore-children onClickOverlay)}}
class={{this.overlayClassNamesString}}
onclick={{action (ignore-children this.onClickOverlay)}}
tabindex="-1"
data-emd-overlay
>
<div class={{containerClassNamesString}}>
<div class={{this.containerClassNamesString}}>
{{yield}}
</div>
</div>
{{else}}
<div class={{containerClassNamesString}}>
<div class={{this.containerClassNamesString}}>
{{yield}}
</div>
{{/if}}
Expand Down
28 changes: 14 additions & 14 deletions addon/templates/components/liquid-tether-dialog.hbs
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
{{#if hasOverlay}}
{{#if this.hasOverlay}}
{{#liquid-wormhole
stack="modal-overlay"
class="liquid-dialog-container"
}}
<div
class={{overlayClassNamesString}}
onclick={{action onClickOverlay}}
class={{this.overlayClassNamesString}}
onclick={{action this.onClickOverlay}}
tabindex="-1"
data-emd-overlay
>
</div>
{{/liquid-wormhole}}
{{/if}}
{{#liquid-tether
class=containerClassNamesString
target=tetherTarget
attachment=attachment
targetAttachment=targetAttachment
targetModifier=targetModifier
classPrefix=tetherClassPrefix
offset=offset
targetOffset=targetOffset
constraints=constraints
stack=stack
value=value
class=this.containerClassNamesString
target=this.tetherTarget
attachment=this.attachment
targetAttachment=this.targetAttachment
targetModifier=this.targetModifier
classPrefix=this.tetherClassPrefix
offset=this.offset
targetOffset=this.targetOffset
constraints=this.constraints
stack=this.stack
value=this.value
}}
{{yield}}
{{/liquid-tether}}
50 changes: 25 additions & 25 deletions addon/templates/components/modal-dialog.hbs
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
{{#component
modalDialogComponentName
wrapperClass=wrapperClass
wrapperClassNames=wrapperClassNames
overlayClass=overlayClass
overlayClassNames=overlayClassNames
containerClass=containerClass
containerClassNames=containerClassNames
hasOverlay=hasOverlay
translucentOverlay=translucentOverlay
clickOutsideToClose=clickOutsideToClose
destinationElementId=destinationElementId
overlayPosition=overlayPosition
tetherTarget=tetherTarget
legacyTarget=target
attachment=attachment
targetAttachment=targetAttachment
targetModifier=targetModifier
targetOffset=targetOffset
offset=offset
tetherClassPrefix=tetherClassPrefix
constraints=constraints
attachmentClass=attachmentClass
targetAttachmentClass=targetAttachmentClass
stack=stack
value=value
this.modalDialogComponentName
wrapperClass=this.wrapperClass
wrapperClassNames=this.wrapperClassNames
overlayClass=this.overlayClass
overlayClassNames=this.overlayClassNames
containerClass=this.containerClass
containerClassNames=this.containerClassNames
hasOverlay=this.hasOverlay
translucentOverlay=this.translucentOverlay
clickOutsideToClose=this.clickOutsideToClose
destinationElementId=this.destinationElementId
overlayPosition=this.overlayPosition
tetherTarget=this.tetherTarget
legacyTarget=this.target
attachment=this.attachment
targetAttachment=this.targetAttachment
targetModifier=this.targetModifier
targetOffset=this.targetOffset
offset=this.offset
tetherClassPrefix=this.tetherClassPrefix
constraints=this.constraints
attachmentClass=this.attachmentClass
targetAttachmentClass=this.targetAttachmentClass
stack=this.stack
value=this.value
onClickOverlay=(action "onClickOverlay")
onClose=(action "onClose")
}}
Expand Down
26 changes: 13 additions & 13 deletions addon/templates/components/tether-dialog.hbs
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
{{#if hasOverlay}}
{{#ember-wormhole to=destinationElementId}}
{{#if this.hasOverlay}}
{{#ember-wormhole to=this.destinationElementId}}
<div
class={{overlayClassNamesString}}
onclick={{action onClickOverlay}}
class={{this.overlayClassNamesString}}
onclick={{action this.onClickOverlay}}
tabindex="-1"
data-emd-overlay
>
</div>
{{/ember-wormhole}}
{{/if}}
{{#ember-tether
class=containerClassNamesString
target=tetherTarget
attachment=attachment
targetAttachment=targetAttachment
targetModifier=targetModifier
classPrefix=tetherClassPrefix
offset=offset
targetOffset=targetOffset
constraints=constraints
class=this.containerClassNamesString
target=this.tetherTarget
attachment=this.attachment
targetAttachment=this.targetAttachment
targetModifier=this.targetModifier
classPrefix=this.tetherClassPrefix
offset=this.offset
targetOffset=this.targetOffset
constraints=this.constraints
}}
{{yield}}
{{/ember-tether}}