[BREAKING] Remove deprecations in anticipation of 3.0.0 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Direct usage of the `tether-dialog` component is no longer supported, �in favor of opting into tethering behavior by passing a `tetherTarget` to `modal-dialog`. - Specifying the `close` action for a `modal-dialog` component is no longer supported in favor of `onClose` - Specifying the `container-class` attribute for a `modal-dialog` component is no longer supported in favor of the camelCase `containerClass` - Specifying the `overlay-class` attribute for a `modal-dialog` component is no longer supported in favor of the camelCase `overlayClass` - Specifying the `wrapper-class` attribute for a `modal-dialog` component is no longer supported in favor of the camelCase `wrapperClass` - Specifying the `target` attribute for a `modal-dialog` component is no longer supported in favor of the `tetherTarget` - Direct usage of the `modal-dialog-overlay` component is no longer supported. Internally, we just use a div now. These were all deprecated with warnings during 2.x, so if you are deprecation-free in 2.4.3, you can safely upgrade to 3.0.0
jamesarosen
reviewed
May 11, 2018
| @@ -70,7 +70,8 @@ export default Component.extend({ | |||
| } | |||
|
|
|||
| // if the click is within the dialog, do nothing | |||
| if (document.querySelector(modalSelector).contains(target)) { | |||
| let modalEl = document.querySelector(modalSelector); | |||
| if (modalEl && modalEl.contains(target)) { | |||
There was a problem hiding this comment.
This is safer, but I'm not sure it's quite correct. If there's no modalEl, it still runs onClose. My impression is that it should be
let modalEl = document.querySelector(modalSelector);
if (!modelEl || modelEl.contains(target)) {
return;
}
this.sendAction('onClose');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tether-dialogcomponent is no longer supported, �in favor of opting into tethering behavior by passing atetherTargettomodal-dialog.closeaction for amodal-dialogcomponent is no longer supported in favor ofonClosecontainer-classattribute for amodal-dialogcomponent is no longer supported in favor of the camelCasecontainerClassoverlay-classattribute for amodal-dialogcomponent is no longer supported in favor of the camelCaseoverlayClasswrapper-classattribute for amodal-dialogcomponent is no longer supported in favor of the camelCasewrapperClasstargetattribute for amodal-dialogcomponent is no longer supported in favor of thetetherTargetmodal-dialog-overlaycomponent is no longer supported. Internally, we just use a div now.These were all deprecated with warnings during 2.x, so if you are deprecation-free in 2.4.3, you can safely upgrade to 3.0.0