Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add element center to positioned container #144

Merged
merged 4 commits into from
Sep 20, 2016
Merged

Add element center to positioned container #144

merged 4 commits into from
Sep 20, 2016

Conversation

wandertosee
Copy link

Modal is centered on clicked element.
modal_positioned_element_center

@lukemelia
Copy link
Contributor

Thanks for putting this together @wandertosee. In order for us to merge this PR, we would need an update to the README docs and the dummy app.

@wandertosee
Copy link
Author

I removed the {{view}} helper from the dummy app views but left the README.md and packages.json references to ember-legacy-views (https://github.com/emberjs/ember-legacy-views) for those using <= Ember 2.4.

FYI - "Extended support for Ember.View and friends until Ember 2.4"

Let me know if I can do anything else.

@lukemelia lukemelia merged commit d5f9f94 into yapplabs:master Sep 20, 2016
@lukemelia
Copy link
Contributor

Thanks for your work on this @wandertosee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants