feat: pass bodyElement to move the ModalDialog inside a specific element #93
cyril-sfci.yml
on: pull_request
Tests
51s
Floating Dependencies
54s
Matrix: try-scenarios
Annotations
10 errors and 10 warnings
|
ember-beta
Process completed with exit code 1.
|
|
ember-lts-4.4
Process completed with exit code 1.
|
|
embroider-optimized
Process completed with exit code 1.
|
|
ember-lts-4.8
Process completed with exit code 1.
|
|
ember-lts-5.4
Process completed with exit code 1.
|
|
ember-canary
Process completed with exit code 1.
|
|
ember-release
Process completed with exit code 1.
|
|
embroider-safe
Process completed with exit code 1.
|
|
ember-lts-4.12
Process completed with exit code 1.
|
|
ember-lts-5.8
Process completed with exit code 1.
|
|
Tests:
addon/components/basic-dialog.js#L2
Don't use computed properties with native classes. Use getters or @Tracked properties instead
|
|
Tests:
addon/components/basic-dialog.js#L4
Use Glimmer components(@glimmer/component) instead of classic components(@ember/component)
|
|
Tests:
addon/components/basic-dialog.js#L26
You cannot use the init() lifecycle hook in non-classic classes, it is a classic lifecycle hook. Convert to using the constructor instead, or add the @classic decorator to the class to mark it as classic
|
|
Tests:
addon/components/basic-dialog.js#L107
Do not use classic ember components lifecycle hooks. Prefer using "@ember/render-modifiers" or custom functional modifiers
|
|
Tests:
addon/components/basic-dialog.js#L154
Do not use classic ember components lifecycle hooks. Prefer using "@ember/render-modifiers" or custom functional modifiers
|
|
Tests:
addon/components/in-place-dialog.js#L2
Use Glimmer components(@glimmer/component) instead of classic components(@ember/component)
|
|
Tests:
addon/components/liquid-dialog.js#L10
You cannot use the init() lifecycle hook in non-classic classes, it is a classic lifecycle hook. Convert to using the constructor instead, or add the @classic decorator to the class to mark it as classic
|
|
Tests:
addon/components/positioned-container.js#L3
Use Glimmer components(@glimmer/component) instead of classic components(@ember/component)
|
|
Tests:
addon/components/positioned-container.js#L17
Native JS classes should be used instead of classic classes
|
|
Tests:
addon/components/positioned-container.js#L17
Please switch to a tagless component by setting `tagName: ''` or converting to a Glimmer component
|