Refactor initializer container lookups into an instanceIntializer

[mike-north]

This addresses an ember-1.11 deprecation warning
http://emberjs.com/deprecations/v1.x/#toc_access-to-instances-in-initializers

[stefanpenner]

this shouldn't be on an InstanceInitializer, it should only be run once, not per instance.,

[mike-north]

ah, good point. Overzealous copypasta FTL

[stefanpenner]

we also likely don't want to add multiple of these, do we tear them down?

[mike-north]

I don't believe they're ever torn down. What's the best practice for an instance UNinitializer?

[stefanpenner]

this isn't an instance initializer though, it should only occur once. That being said, it likely just be something the application view does, as that has the right life-cycle and scope.

Unfortunately, each approach appears pretty lame.

But for reference, the eventdispatcher (which this ultimately augments) is created at app boot, and removed at app teardown.

[lukemelia]

I am correct that this breaks compatibility with Ember 1.10? That may be fine, I just want to verify so we can message accordingly.

[mike-north]

I think we don't have to lose 1.10 compatibility if we're clever. My suggestion for moving forward is the following:

• Add the instance initializer for any code that needs access to an instance of an app. This will be a dormant object in the container for apps running < 1.11.0, but it shouldn't be harmful
• Add a condition, whereby for older ember versions, the entire initializer runs as it exists now. For >= 1.11.0, we'll only run part of the initializer, and the rest will be handled by the instanceInitializer.

I have built a thorough regex to extract the necessary version info from Ember.VERSION - http://www.regexr.com/3b274 since we seem to deviate from SemVer for certain versions made available through the release channel (i.e., 1.12.0.94b8cb6c does not seem to be valid according some implementations of SemVer parsing)

Thoughts @stefanpenner @lukemelia ? IMO the alternative is branching for pre/post 1.11.0

[lukemelia]

@truenorth I'm +1 on your approach.

[mike-north]

ping

[lukemelia]

Thanks @truenorth!