Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional geoData property as alternative to geofile #53

Merged
merged 3 commits into from
Sep 16, 2019

Conversation

dpraul
Copy link
Contributor

@dpraul dpraul commented Sep 16, 2019

Hi again!

We need to use d3-geomap in an environment where fetch is not available, and we already have the TopoJSON contents loaded on the page, so I've added the geoData key as an alternative to geofile.

You can pass the TopoJSON contents in directly to the geoData property. In doing so, the geofile property is ignored, and fetch becomes an optional dependency. No other functionality should be affected.

I also added some inline docs for clarity :)

@yaph yaph merged commit 88f5665 into yaph:master Sep 16, 2019
@yaph
Copy link
Owner

yaph commented Sep 16, 2019

Thanks for adding this useful feature.

@dpraul
Copy link
Contributor Author

dpraul commented Sep 18, 2019

thanks for merging this so quickly! do you intend to do a release anytime soon?

@yaph
Copy link
Owner

yaph commented Sep 18, 2019

Yes, not sure yet if this week or beginning of next week.

@yaph
Copy link
Owner

yaph commented Sep 24, 2019

New release is out.

@dpraul
Copy link
Contributor Author

dpraul commented Sep 24, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants