Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use macos-13/14 runner #40

Merged
merged 14 commits into from
Sep 6, 2024
Merged

fix: use macos-13/14 runner #40

merged 14 commits into from
Sep 6, 2024

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Aug 29, 2024

GH removed macos-11 runner as of June 2024: https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/.

Now there are macos-13 and macos-14 runners. The first is still x64 the latter is arm64 so we can build without cross compiling

@robertsLando
Copy link
Member Author

robertsLando commented Aug 29, 2024

@robertsLando robertsLando mentioned this pull request Aug 29, 2024
@axi92
Copy link

axi92 commented Aug 29, 2024

I am not sure but according to this https://github.com/actions/runner-images?tab=readme-ov-file#available-images
macos-13 should be intel?
and
macos-14 should be arm?

@robertsLando
Copy link
Member Author

@axi92 Should be yeah but seems that macos-arm build are failing when using macos-14

@robertsLando
Copy link
Member Author

robertsLando commented Sep 4, 2024

@faulpeltz this is another blocker, macos build fails: #40 (comment)

I have jsut triggered a new build let's see how that goes

@robertsLando robertsLando changed the title fix: use macos-13 runner fix: use macos-13/14 runner Sep 4, 2024
@robertsLando
Copy link
Member Author

robertsLando commented Sep 4, 2024

@robertsLando
Copy link
Member Author

Cool new issue: nodejs/node#52230

@robertsLando
Copy link
Member Author

Seems runner run out of RAM, new try with a limit on jobs:

https://github.com/yao-pkg/pkg-fetch/actions/runs/10717836953

@robertsLando
Copy link
Member Author

With the fix now the x64 seems working but the arm64 is still failing. Try to re-enable cross build with less jobs:

https://github.com/yao-pkg/pkg-fetch/actions/runs/10722148089

@robertsLando
Copy link
Member Author

robertsLando commented Sep 5, 2024

Try to use pip for nodejs 18 and brew on 20:

https://github.com/yao-pkg/pkg-fetch/actions/runs/10722955285

Everything is green 🎉 🎉 🎉 🎉

@robertsLando robertsLando merged commit f79b7a3 into main Sep 6, 2024
13 checks passed
@robertsLando robertsLando deleted the macos-13 branch September 6, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants