Fix export manifest with multiple locales

yao-msft · Jun 20, 2024 · d2eae39 · d2eae39
1 parent 38aac87
commit d2eae39
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/src/AppInstallerCLITests/YamlManifest.cpp b/src/AppInstallerCLITests/YamlManifest.cpp
@@ -1289,6 +1289,18 @@ TEST_CASE("WriteV1_7SingletonManifestAndVerifyContents", "[ManifestCreation]")
     VerifyV1ManifestContent(generatedMultiFileManifest, false, ManifestVer{ s_ManifestVersionV1_7 }, true);
 }
 
+TEST_CASE("WriteManifestWithMultipleLocale", "[ManifestCreation]")
+{
+    Manifest multiLocaleManifest = YamlParser::CreateFromPath(TestDataFile("Manifest-Good-MultiLocale.yaml"));
+    TempDirectory exportedDirectory{ "exported" };
+    std::filesystem::path generatedManifestPath = exportedDirectory.GetPath() / "testManifestWithMultipleLocale.yaml";
+    YamlWriter::OutputYamlFile(multiLocaleManifest, multiLocaleManifest.Installers[0], generatedManifestPath);
+
+    REQUIRE(std::filesystem::exists(generatedManifestPath));
+    Manifest generatedManifest = YamlParser::CreateFromPath(generatedManifestPath);
+    REQUIRE(generatedManifest.Localizations.size() == 2);
+}
+
 YamlManifestInfo CreateYamlManifestInfo(std::string testDataFile)
 {
     YamlManifestInfo result;

diff --git a/src/AppInstallerCommonCore/Manifest/YamlWriter.cpp b/src/AppInstallerCommonCore/Manifest/YamlWriter.cpp
@@ -610,14 +610,14 @@ namespace AppInstaller::Manifest::YamlWriter
             {
                 out << YAML::Key << Localization;
                 out << YAML::BeginSeq;
-                out << YAML::BeginMap;
 
                 for (const auto& localization : localizations)
-                {
-                    ProcessLocaleFields(out, localization);
+                {
+                    out << YAML::BeginMap;
+                    ProcessLocaleFields(out, localization);
+                    out << YAML::EndMap;
                 }
 
-                out << YAML::EndMap;
                 out << YAML::EndSeq;
             }
         }
@@ -669,4 +669,4 @@ namespace AppInstaller::Manifest::YamlWriter
         emitter.Emit(outFileStream);
         outFileStream.close();
     }
-}
+}