Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project, I'm using worker_thread (by workerpool) to asynchronize and speed up heavy works to avoid main thread blocking.
But nodejieba is not compatible to be used with worker_thread. According to josdejong/workerpool#165, Automattic/node-canvas#1394 and nodejs/nan#844 (comment), it seems that we can simply change
NODE_MODULE
intoNAN_MODULE_WORKER_ENALBED
macro to make it compatible.Tests:
npm test
all test is passing