Add methods to write Package to any Write + Seek #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickfunk
approved these changes
Jul 29, 2023
|
Now live on https://crates.io/crates/genanki-rs/0.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for your work on genanki-rs.
I'm working on a server that in one of its endpoints generates and serves an Anki deck as a download, and currently that requires creating a temporary file and reading it after writing the Package to it. Not a big deal, but this API would make it a little nicer. I opted not to add similar methods to Deck, as I think this is a more niche use case so it's ok to keep Deck's methods simple.
I wasn't able to run all of the tests locally, but the changes are pretty straightforward so hopefully everything should be in working order.