Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for your work on genanki-rs.
I got an error when using a randomly generated Model id because it was too large (
out of range integral type conversion attempted
). The error occurred here:genanki-rs/src/note.rs
Lines 168 to 185 in 6ddffe9
I was also able to reproduce a similar error by trying to use a large Deck id. It seems like the cause is that the integer used in SQLite is an i64. Anki doesn't seem to mind negative model or deck ids, so this PR changes the ids to be i64 to avoid this kind of error. Note ids seem to be unaffected so I didn't change them.