Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(output/tap): Output qualified resource name #88

Merged
merged 1 commit into from
Dec 18, 2021
Merged

feat(output/tap): Output qualified resource name #88

merged 1 commit into from
Dec 18, 2021

Conversation

maxbrunet
Copy link
Contributor

This is an improvement suggestion for the TAP output. With only the resource kind in the output, it can be impossible to know which resource is being validated:

ok 48 - stdin (RoleBinding)
ok 49 - stdin (RoleBinding)
ok 50 - stdin (RoleBinding)
ok 51 - stdin (RoleBinding)

This PR replaces the resource kind by a "qualified" resource name formatted version/kind/namespace/name:

ok 48 - stdin (rbac.authorization.k8s.io/v1/RoleBinding/ns1/admin)
ok 49 - stdin (rbac.authorization.k8s.io/v1/RoleBinding/ns2/admin)
ok 50 - stdin (rbac.authorization.k8s.io/v1/RoleBinding/ns3/admin)
ok 51 - stdin (rbac.authorization.k8s.io/v1/RoleBinding/ns4/admin)

It also adds the signature to skipped resources:

ok 25 #skip - stdin
ok 24 - stdin (bitnami.com/v1alpha1/SealedSecret/some-ns/a-secret) # skip

@yannh
Copy link
Owner

yannh commented Dec 18, 2021

Small comment on the format, otherwise nice improvement 💯

@yannh yannh merged commit c32562e into yannh:master Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants