Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to set an alternative image owner #164

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

LinuxSuRen
Copy link
Contributor

@LinuxSuRen LinuxSuRen commented Jan 11, 2023

This is useful when contributors want to test their pull request. And even they could use their pull request before it got merged.

@yannh
Copy link
Owner

yannh commented Jan 22, 2023

This would break running goreleaser locally, though I really like making this easier to fork. Think you could fix the Makefile as well so goreleaser still works when not run in Github Actions? 🙏

@LinuxSuRen
Copy link
Contributor Author

Goreleaser could work well without GitHub Actions. Because I provided the environment variables.

@yannh yannh merged commit 9860cde into yannh:master Jan 25, 2023
@yannh
Copy link
Owner

yannh commented Jan 25, 2023

Yes thank you this looks good! ✔️

@LinuxSuRen LinuxSuRen deleted the feat/image-owner branch January 25, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants