Skip to content
This repository has been archived by the owner on Feb 26, 2022. It is now read-only.

Static markup #53

Merged
merged 4 commits into from
Jun 29, 2018
Merged

Static markup #53

merged 4 commits into from
Jun 29, 2018

Conversation

stephenp
Copy link
Contributor

We wanted to visually separate out the static and react components in the storybook UI, this PR addresses the issue.

Risks

None / Low

Changes

  • No visual changes to components
  • Visual changes to storybook UI (added subsections for react components and static components)

Issue

Addresses: #16

@stephenp stephenp requested review from bernabe9, jstnjns and a-axton June 29, 2018 20:22
@stephenp stephenp self-assigned this Jun 29, 2018
@stephenp stephenp added the enhancement Feature enhancement to existing code label Jun 29, 2018
@jstnjns
Copy link
Collaborator

jstnjns commented Jun 29, 2018

Can we use the headers outlined here?

#16 (comment)

static = foundation
react = components

@stephenp
Copy link
Contributor Author

Updated naming per #16

@stephenp stephenp merged commit 8188ffc into develop Jun 29, 2018
@stephenp stephenp deleted the static-markup branch June 29, 2018 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Feature enhancement to existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants