Skip to content

Commit

Permalink
adjusting overload of fractions.Fraction.__new__ (python#13241)
Browse files Browse the repository at this point in the history
  • Loading branch information
tungol authored Dec 14, 2024
1 parent 364fd7d commit acebd50
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion stdlib/@tests/stubtest_allowlists/common.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ contextlib._GeneratorContextManagerBase.__init__ # skipped in the stubs in favo
ctypes.CDLL._FuncPtr # None at class level but initialized in __init__ to this value
ctypes.memmove # CFunctionType
ctypes.memset # CFunctionType
fractions.Fraction.__new__ # overload is too complicated for stubtest to resolve
http.client.HTTPConnection.response_class # the actual type at runtime is abc.ABCMeta
importlib.abc.Loader.exec_module # See Lib/importlib/_abc.py. Might be defined for backwards compatibility
importlib.abc.MetaPathFinder.find_spec # Not defined on the actual class, but expected to exist.
Expand Down
4 changes: 2 additions & 2 deletions stdlib/fractions.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ class Fraction(Rational):
@overload
def __new__(cls, numerator: int | Rational = 0, denominator: int | Rational | None = None) -> Self: ...
@overload
def __new__(cls, value: float | Decimal | str, /) -> Self: ...
def __new__(cls, numerator: float | Decimal | str) -> Self: ...

if sys.version_info >= (3, 14):
@overload
def __new__(cls, value: _ConvertibleToIntegerRatio) -> Self: ...
def __new__(cls, numerator: _ConvertibleToIntegerRatio) -> Self: ...

@classmethod
def from_float(cls, f: float) -> Self: ...
Expand Down

0 comments on commit acebd50

Please sign in to comment.