Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace %env magic with os.environ #283

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

dniku
Copy link
Collaborator

@dniku dniku commented Sep 5, 2019

This ensures that future attempts to autoformat the code won't break it again.

This PR also removes a reference to THEANO_FLAGS from week06_policy_based/reinforce_tensorflow.ipynb.

This ensures that future attempts to autoformat the code won't break it again.
@dniku dniku self-assigned this Sep 5, 2019
@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/yandexdataschool/Practical_RL/pull/283

You'll be able to see notebook diffs and discuss changes. Powered by ReviewNB.

Copy link
Collaborator

@yhn112 yhn112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't work? Now works? LGTM

@dniku dniku merged commit dcc7fb8 into master Sep 5, 2019
@dniku dniku deleted the master-replace-env-magic-with-os-environ branch September 5, 2019 22:09
yhn112 pushed a commit that referenced this pull request Jan 24, 2020
This ensures that future attempts to autoformat the code won't break it again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants