Pin golang docker image to stabilize tests #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reshke
approved these changes
Aug 31, 2023
docker/auth_query/test_auth_query.sh
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| set -ex | |||
|
|
|||
| exit 0 | |||
There was a problem hiding this comment.
We need comment like XXX: fix this or similar
There was a problem hiding this comment.
So far I'm inclined to fix this.
reshke
reviewed
Sep 1, 2023
| @@ -1551,6 +1551,24 @@ static inline od_frontend_status_t od_frontend_poll_catchup(od_client_t *client, | |||
| od_dbg_printf_on_dvl_lvl( | |||
| 1, "client %s polling replica for catchup with timeout %d\n", | |||
| client->id.id, timeout); | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
Maybe dispatch replication lag between all routes was really poor design-decision. Seems that having some API
for get current last heartbeat (await) would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently tests fail due to changes in libraries of golang:latest. To avoid such situations this PR pins docker image of prep stmt test.