remove hardcoded implicitlywait #82
Conversation
|
|
||
| public static int getTimeOutInSeconds() { | ||
| try { | ||
| return Integer.valueOf(System.getProperty("webdriver.timeouts.implicitlywait")); |
There was a problem hiding this comment.
It would be great if this can be overridden on per-element level using a @Timeout annotation for example.
There was a problem hiding this comment.
Timeout annotation have been added
|
@artkoshelev is there any updates? |
|
test this please |
| } catch (NoSuchMethodException | InvocationTargetException | IllegalAccessException e) { | ||
| } | ||
|
|
||
| return 1; |
There was a problem hiding this comment.
we should return 5 here to keep backward compatibility with previous implementation
There was a problem hiding this comment.
we should return 5 here to keep backward compatibility with previous implementation
in that case I have to add annotations for all elements in my project for changing value less than 5 seconds. It's redundant for me 👎
There was a problem hiding this comment.
can you suggest any solution to this problem?
There was a problem hiding this comment.
Will be this solution good for you?
private int getDefaultTimeOut() {
try {
return Integer.valueOf(System.getProperty("webdriver.timeouts.implicitlywait"));
} catch (NumberFormatException ex) {
return 5;
}
}
There was a problem hiding this comment.
There is default method to get integer from property with default value
There was a problem hiding this comment.
Do you mean this case?
Integer.getInteger(System.getProperty("webdriver.timeouts.implicitlywait"), 5);
There was a problem hiding this comment.
Just Integer.getInteger("webdriver.timeouts.implicitlywait", 5);
|
test this please |
|
|
||
| public int getTimeOut(Field field) { | ||
| if (field.isAnnotationPresent(Timeout.class)) { | ||
| return field.getDeclaredAnnotation(Timeout.class).value(); |
There was a problem hiding this comment.
getDelcaredAnnotation(Class) method is not available in java7, please refactor this place to keep java7-compatible
@eroshenkoam @artkoshelev |
|
@emaks don't worry about 'test this please' it's just a phrase to run jenkins build |
|
@artkoshelev |
|
@emaks Please add test with system property usage |
done |
|
LGTM |
remove hardcoded implicitlywait
|
good job, landed! |
|
@artkoshelev Could you, please, tell me when next release will be? |
pull request for issue #78