In HtmlElementUtils.newInstance added optional parameter "outerObject". #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement TypifiedElement implement WebElement
StaleElementReferenceException fix
Also a few formatting and wording tweaks.
…tting, corrected typos and enhanced a test. (yandex-qatools#119)
…f-bounds Landed, thank you!
… interactions with browser
…-issue-in-table Fix performance issue in table
Kin-k
changed the title
qatools-ci
reviewed
Nov 27, 2016
| if (clazz.isMemberClass() && !Modifier.isStatic(clazz.getModifiers())) { | ||
| Class outerClass = clazz.getDeclaringClass(); | ||
| Object outerObject = outerClass.newInstance(); | ||
| public static <T> T newInstance(Object outerObject, Class<T> clazz, Object... args) |
There was a problem hiding this comment.
Refactor this method to throw at most one checked exception instead of: java.lang.IllegalAccessException, java.lang.InstantiationException, java.lang.NoSuchMethodException, java.lang.reflect.InvocationTargetException 
qatools-ci
reviewed
Nov 27, 2016
| if (isHtmlElement(field)) | ||
| return decorateHtmlElement(loader, outerObject, field); | ||
| } | ||
| catch (ClassCastException ignore) {} |
There was a problem hiding this comment.
Either remove or fill this block of code.
Either log or rethrow this exception.
|
SonarQube analysis reported 3 issues:
Watch the comments in this conversation to review them. |
eroshenkoam
force-pushed
the
master
branch
2 times, most recently
from
58b45bf
to
1c8583b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Без этого возникает проблема с вложенными inner-классами HtmlElement-ов.
outerClass.newInstance() - создаёт новый объект outer-класса, для которого запускается популейт, который опять выполняет newInstance для поля, являющегося объектом класса inner-класса.
В котором опять outerClass.newInstance(). В результате вечная рекурсия.