Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi !
Working with Ctypes I realized I needed a
CArray.iteri
method in order to iter over a carray passing the index to the argument function.As it doesn't exist I felt it was time for me to do my first open source PR :)
Type of change
val iteri : (int -> 'a -> unit) -> 'a t -> unit
This is a new feature, non breaking that just adds a functionality.
How Has This Been Tested?
I tried to stick with testing and coding style of the already existing
CArray.iter
function:9 = (0 + 1 ) + (1 + 2 ) + (2 + 3)
If you believe this change is futile for the code base
No worry, I just wanted to learn how to do an opensource PR.