Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken test that calls an expired closure. #773

Merged
merged 1 commit into from
May 20, 2024

Conversation

yallop
Copy link
Owner

@yallop yallop commented May 20, 2024

As the comment says:

(* ...
  The value of this test is questionable: calling an expired closure does not
  have defined behaviour, since the structures needed to make the call may
  have been garbage collected.
*)

and there's even less value in the test than there once was, since it's now reliably broken in practice on macOS.

@yallop yallop merged commit 66dd5f0 into master May 20, 2024
33 checks passed
@yallop yallop deleted the remove-broken-lifetime-test branch May 20, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant