Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate tests in TestBase #72

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Consolidate tests in TestBase #72

merged 1 commit into from
Dec 20, 2021

Conversation

amirebrahimi
Copy link
Collaborator

Resolves #71

  • Added base.py, which has TestBase
  • For generality, both X and Z readouts are performed on all tests now

@amirebrahimi amirebrahimi requested a review from Phionx December 11, 2021 04:29
Phionx
Phionx approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@Phionx Phionx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as these tests are running locally, this LGTM!

tests/base.py Show resolved Hide resolved
@amirebrahimi amirebrahimi merged commit bd952a3 into master Dec 20, 2021
@amirebrahimi amirebrahimi deleted the fix/71/tests-x-readout branch December 20, 2021 01:02
@Phionx Phionx added this to the 0.2.0 milestone Dec 25, 2021
@amirebrahimi amirebrahimi mentioned this pull request Jan 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phionx Phionx Phionx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

[tests] update XXZZ and XZZX tests to accommodate errors that affect logical X readout
2 participants
@amirebrahimi @Phionx