Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase-flip-protected repetition qubit #69

Merged
merged 6 commits into from
Dec 11, 2021

Conversation

amirebrahimi
Copy link
Collaborator

Resolves #66

The one question I have is whether the |+x> state should be prepared and if we should be measuring in the X basis? I kept it as is with |+z> and measuring in the Z basis because that is how we run the tests for the XXZZ qubit even though we test individual phase flips as well.

@amirebrahimi amirebrahimi requested a review from Phionx December 7, 2021 06:57
Copy link
Member

@Phionx Phionx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with this PR!

I did leave a few minor comments, as well as a major comment about tests.

Also, were you able to resolve the issue we were running into with 1D lattices, where we had extra nodes in the syndrome graph?

qtcodes/circuits/repetition.py Outdated Show resolved Hide resolved
qtcodes/circuits/repetition.py Outdated Show resolved Hide resolved
qtcodes/fitters/repetition.py Outdated Show resolved Hide resolved
qtcodes/fitters/repetition.py Outdated Show resolved Hide resolved
tests/rep.py Show resolved Hide resolved
tests/rep.py Outdated Show resolved Hide resolved
@Phionx Phionx mentioned this pull request Dec 10, 2021
@amirebrahimi
Copy link
Collaborator Author

amirebrahimi commented Dec 10, 2021

Great work with this PR!

I did leave a few minor comments, as well as a major comment about tests.

Also, were you able to resolve the issue we were running into with 1D lattices, where we had extra nodes in the syndrome graph?

Yes, that was fixed with my previous PR: #65.

Copy link
Member

@Phionx Phionx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amirebrahimi amirebrahimi merged commit fbbe82e into master Dec 11, 2021
@amirebrahimi amirebrahimi deleted the feature/66/phase-flip-protected-repetition branch December 11, 2021 03:56
@Phionx Phionx added this to the 0.2.0 milestone Dec 25, 2021
@Phionx Phionx linked an issue Mar 7, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants