-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase-flip-protected repetition qubit #69
Phase-flip-protected repetition qubit #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with this PR!
I did leave a few minor comments, as well as a major comment about tests.
Also, were you able to resolve the issue we were running into with 1D lattices, where we had extra nodes in the syndrome graph?
Yes, that was fixed with my previous PR: #65. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves #66
The one question I have is whether the |+x> state should be prepared and if we should be measuring in the X basis? I kept it as is with |+z> and measuring in the Z basis because that is how we run the tests for the XXZZ qubit even though we test individual phase flips as well.