Makefile escape # pound char (#56)

* # needs to be escaped in make * set relase
yakworks · Jul 21, 2022 · 9c9daa2 · 9c9daa2
1 parent 88facff
commit 9c9daa2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/makefiles/vault.make b/makefiles/vault.make
@@ -21,7 +21,9 @@ endif
 
 ifneq ($(wildcard $(VAULT_BOT_ENV_FILE)),)
   include $(VAULT_BOT_ENV_FILE)
-  VAULT_ENV_VARS := $(shell sed '/^#.*/d; /^$$/d; s/=.*//g;' $(VAULT_BOT_ENV_FILE))
+  # $ need to be escaped with another $ and # need to be escaped with a normal \
+  cmd = sed '/^\#.*/d; /^$$/d; s/=.*//g;' $(VAULT_BOT_ENV_FILE)
+  VAULT_ENV_VARS := $(shell $(cmd))
   # $(info including $(VAULT_ENV_VARS) from $(VAULT_ENV_FILE))
   export $(VAULT_ENV_VARS)
 endif

diff --git a/version.properties b/version.properties
@@ -8,4 +8,4 @@ publishedVersion=2.0.4
 # when this is false will append -SNAPSHOT to version and if on publishable branch will 'publish' to snapshotUrl
 # when true IS_RELEASEBALE will be set and will go through full release process cycle to
 # automatically bump version and push a v tag to github
-release=false
+release=true