Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade for ES0.90.4 #5

Closed
wants to merge 1 commit into from
Closed

Upgrade for ES0.90.4 #5

wants to merge 1 commit into from

Conversation

baxford
Copy link
Contributor

@baxford baxford commented Sep 23, 2013

Hi,

thanks for this plugin! I need to use it against ES 0.90.4 so I've made 2 changes:
Firstly removed the splitIndices/splitTypes methods as they are removed by this commit:
elastic/elasticsearch#3680

Also, the org.elasticsearch.common.collect.Sets type utilities seem to have been removed, so I've just replaced these with new HashSet etc.

Please let me know if this is ok.

ofavre pushed a commit that referenced this pull request Sep 25, 2013
Adapt to ElasticSearch v0.90.4 + Bump to 1.3.0
a9009f3 
RefreshRequestBuilder.setWaitForOperations() seemed to have to impact,
and was removed. The setForce() function seems to have another use.

See #5.
@ofavre
Copy link
Contributor

ofavre commented Sep 25, 2013

I don't understand why you say that org.elasticsearch.common.collect.Sets and friends were removed.
They still seem to be accessible from ES current master.
They come from the shaded guava dependency, and they are still shipped with version 15.0.

You introduced an asymmetry between readFrom() and writeTo() in org.elasticsearch.action.updatebyquery.IndexUpdateByQueryRequest.
This will lead to bugs.

I do not wish to change the imports in order to ease following changes done to elastic/elasticsearch#2230.

Otherwise, the core of your changes seem fine.
Take a look at a9009f3 and tell me if it looks good for you too.
I'll then release it.

Thanks for contributing!

@consulthys
Copy link

Awesome job, thanks!
Any chance to be able to install it directly from the repo? I had to clone the repo and build the latest release manually.
Thanks much.

@ofavre
Copy link
Contributor

ofavre commented Oct 7, 2013

v1.3.0 released.
Please count a couple of hours before it actually gets synced to Maven Central Repository.

@ofavre ofavre closed this Oct 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baxford @ofavre @consulthys