-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed setPassword body is compressed #8790
Conversation
+ Updated server to also use the correct Basic implementation
Also this needs 100% rollout I guess for touhidurrr/UncivServer.xyz#5 to be merged. |
@GGGuenni @yairm210 I think we need to use domains or groups as keys. Currently,
|
In solution 2, the client will keep track of domains under a group and then group password. const settings = {
groups: {
["uncivserver.xyz"]: {
passwords: {
userId: "password",
},
hostnames: ["uncivserver.xyz", "replit.uncivserver.xyz"],
},
},
}; or, const settings = {
hostToGroupMap: {
["uncivserver.xyz"]: "uncivserver.xyz",
["replit.uncivserver.xyz"]: "uncivserver.xyz",
},
groupPasswords: {
["uncivserver.xyz"]: {
userId: "password",
},
},
}; for easy access. const isAlive = {
authVersion: 2,
group: "uncivserver.xyz",
hosts: ["uncivserver.xyz", "replit.uncivserver.xyz", "bd.uncivserver.xyz"],
}; |
What are you using the The only thing I see that might be a problem is setting the password for one changes the password for the other (if the server is implemented that way). But I don't think that's a huge problem. If you change the password and switch the domain you will be asked for a password once and that's it |
Basically the database is the same, but the server is different. That subdomain runs on a different virtual server. |
@GGGuenni server error message is not being displayed on client on set password failure after touhidurrr/UncivServer.xyz@dd4a244, can you fix this? |
Since I can only change future releases (or the current with hotfixes) it does not make any difference if I change something. |
I am targeting the next release actually. |
Still applies that it will not trigger as 4.5.3+ users will not get the message but are the first ones which could receive it |
Everything should be done client-wise once this is merged if you don't have any more issues @oynqr @touhidurrr