Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using keyboard to select whitelisted item in Firefox fails #28

Closed
ghost opened this issue Sep 3, 2017 · 3 comments
Closed

Using keyboard to select whitelisted item in Firefox fails #28

ghost opened this issue Sep 3, 2017 · 3 comments
Labels

Comments

@ghost
Copy link

ghost commented Sep 3, 2017

Firefox 55.0.0.2 on Ubuntu

Using the most recent commit from the GitHub repo and the demo index.html.

  1. Type, "A#" to display two whitelisted suggestions
  2. Use the down arrow on the keyboard to select one of the suggestions
  3. Rather than the selected suggestion being added to the field, the typed letters ("A#") are added

The behaviour is as expected in Chromium 60 on Ubuntu. The behaviour is expected in both browsers if the mouse is used instead of the keyboard to select one of the suggestions.

I will look at this myself now but any suggestions welcome.

@ghost
Copy link
Author

ghost commented Sep 4, 2017

Looks like this issue is due to a difference in how browsers handle events from the datalist element.

whatwg/html#2605.

@ghost ghost mentioned this issue Sep 5, 2017
@yairEO
Copy link
Owner

yairEO commented Sep 21, 2017

yeah... this sure sucks. I did not want to implement my own dropdown suggestion box, because that would really inflate the code. It would require a positioning system and events..

I will contemplate about if it's worth bloating the code for the sake of better suggestions support.

@yairEO yairEO closed this as completed Sep 21, 2017
@yairEO yairEO added the Bug label Sep 21, 2017
@yairEO yairEO reopened this Sep 21, 2017
@yairEO yairEO mentioned this issue Sep 21, 2017
yairEO added a commit that referenced this issue Jun 15, 2018
@yairEO yairEO closed this as completed Jun 17, 2018
@yairEO
Copy link
Owner

yairEO commented Jun 17, 2018

re-made the whole suggestions dropdown, take a look in the demo page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant