time support #57
time support #57
Conversation
| } | ||
| var value = context[depth]; | ||
| if(!Array.isArray(value)) { | ||
| var keys = this.precedenceMap[value]; |
There was a problem hiding this comment.
Can you consolidate this code with code from lines 213-228? Looks like they do the same thing.
| @@ -236,7 +439,7 @@ Ycb.prototype = { | |||
| _contextToObject: function(context) { | |||
| var contextObj = {}; | |||
| for(var i=0; i<context.length; i++) { | |||
| if(context[i] !== '0') { | |||
| if(context[i] !== 0) { | |||
There was a problem hiding this comment.
why is it a number now?
There was a problem hiding this comment.
The context array is built from the map keys which are numbers, before these were js objects so the keys were getting converted to strings.
| @@ -52,6 +54,14 @@ function omit(obj, omitKey) { | |||
| }, {}); | |||
| } | |||
|
|
|||
| function logBundleWarning(index, message, value) { | |||
There was a problem hiding this comment.
instead of just warning, do we want to throw at all? i guess in the context of a live config scenario, you wouldn't want to just start breaking the server if a config is formatted incorrectly.
There was a problem hiding this comment.
This is patterned after the older version's behavior. Seems safer to match that at least by default. If there is a use case where calling code would want to handle these errors somehow we could add an option to throw. I assume live config could catch this and simply not swap in the broken config.
| continue; | ||
| } | ||
| if(!configObj.settings) { | ||
| if(!configObj.dimensions) { |
There was a problem hiding this comment.
dimensions is not required right?, the old syntax should still work
There was a problem hiding this comment.
This check prevents an erroneous warning log from the dimensions object in the bundle.
| cmp([0,7,0], ycb._parseContext({region:'fr'})); | ||
| cmp([0,6,9], ycb._parseContext({flavor:'bt', region:'ir'})); | ||
| cmp([2,7,8], ycb._parseContext({lang:'fr_FR', region:'fr', flavor:'att'})); | ||
| cmp([0,4,0], ycb._parseContext({region:'fr'})); |
There was a problem hiding this comment.
Unused dimension values with used ancestor values were getting assigned distinct labels to even though they are functionally equivalent to their ancestor. This change maps them to the ancestor instead.
@redonkulus
Adds support for time based configuration.
Scheduled configurations may be defined in the following way
Either
startorendmay be omitted to define a one sided interval. Any string that can be parsed by the builtinDateand converted to an epoch timestamp should work.To make use of scheduled configs you must use
readTimeAwareorreadNoMergeTimeAware, this take a context and a timestamp in milliseconds.Time configs are merged in order of start time.
Caching
To support caching you may pass the option
cachInfo: trueon time aware calls. Ycb will add a field atYCB.EXPIRATION_KEYon the returned config denoting the next time this value will change. If it will not change in the future then this field is not added.For non-merging reads this field will be added to the first config only.
The new method
getCacheKey(context)converts a context object into a string. The output may only be equal if corresponding read calls would return the same result.I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.