Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump chai from 4.3.7 to 4.3.8 #434

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 30, 2023

Bumps chai from 4.3.7 to 4.3.8.

Release notes

Sourced from chai's releases.

v4.3.8

What's Changed

New Contributors

Full Changelog: chaijs/chai@v4.3.7...v4.3.8

Commits
Maintainer changes

This version was pushed to npm by keithamus, a new releaser for chai since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 30, 2023
@redonkulus
Copy link
Contributor

@pablopalacios many of these tests seems to be timing out now, any ideas why the URL parsing is failing?

@pablopalacios
Copy link
Contributor

pablopalacios commented Aug 30, 2023

@redonkulus very likely because of the node version. I see that tests are failing since node 18 support was added. In node 18, fetch was added to node. The implemention is based on undici which doesn't use the http library behind it. This means that the library we are using to mock fetch is not effective anymore. But this is just a guess, in 2 weeks I might have more time to take a deeper look at it.

@pablopalacios
Copy link
Contributor

It seems to be hairy: nodejs/undici#2155

@pablopalacios
Copy link
Contributor

And here is my proposal: #437

@redonkulus
Copy link
Contributor

@dependabot rebase

Bumps [chai](https://github.com/chaijs/chai) from 4.3.7 to 4.3.8.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/4.x.x/History.md)
- [Commits](chaijs/chai@v4.3.7...v4.3.8)

---
updated-dependencies:
- dependency-name: chai
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/chai-4.3.8 branch from 3c31880 to 4289353 Compare August 30, 2023 22:42
@redonkulus redonkulus merged commit ac40e81 into master Aug 30, 2023
2 checks passed
@redonkulus redonkulus deleted the dependabot/npm_and_yarn/chai-4.3.8 branch August 30, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants