Update README #810
Open
Update README #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DennisMcWherter
requested changes
May 9, 2019
| @@ -33,7 +33,7 @@ To actually start your Elide application, add the following to your main method: | |||
|
|
|||
| ```java | |||
| public class Main { | |||
| public static void main(String[] args) { | |||
| public static void main(String[] args) throws Exception { | |||
There was a problem hiding this comment.
Rather than adding the unchecked exception to the signature, I would suggest adding it to the javadoc. Especially since this is on the main method, there is no one else to really catch it.
Same comment for the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # (if appropriate)
Description
Elide standalone startup throws unchecked exception which hasn't been captured in doc yet
A docker image has been introduced to give new users a quicker and easier experience of Elide (If core team likes it)
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):