Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JPA DataStore #747

Merged
merged 15 commits into from
Apr 7, 2019
Merged

Implement JPA DataStore #747

merged 15 commits into from
Apr 7, 2019

Conversation

wcekan
Copy link
Contributor

@wcekan wcekan commented Feb 14, 2019

Rebased from #651

DataStore with only javax.persistence dependency.
Can be used with any JEE container.
Supports both JTA and Non-JTA transactions.

@coveralls
Copy link
Collaborator

coveralls commented Feb 15, 2019

Coverage Status

Coverage increased (+0.05%) to 76.163% when pulling f0114e6 on feature/datastore-jpa into cddb883 on master.

@wcekan
Copy link
Contributor Author

wcekan commented Feb 15, 2019

@belovaf @aklish Please review the rebase and merge.

For the next step I would like to try to move the common code to shared common superclasses that will support any JPA library. Hibernate 3 and 5 should simply subclass and add the required wrappers.

<parent>
<groupId>com.yahoo.elide</groupId>
<artifactId>elide-datastore-parent-pom</artifactId>
<version>4.3.1-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated to 4.3.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in the merge.

<dependency>
<groupId>com.yahoo.elide</groupId>
<artifactId>elide-datastore-hibernate</artifactId>
<version>4.3.1-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment.

<dependency>
<groupId>com.yahoo.elide</groupId>
<artifactId>elide-integration-tests</artifactId>
<version>4.3.1-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

ArrayList<Class<?>> bindClasses = new ArrayList<>();

try {
bindClasses.addAll(ClassScanner.getAnnotatedClasses(Parent.class.getPackage(), Entity.class));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need more than this now. This only covers one package. You will need to include elide-example-models as well.

@aklish
Copy link
Member

aklish commented Mar 6, 2019

We should switch Elide-Standalone to use this along with the H2 in memory DB.

@aklish aklish merged commit 418b7f2 into master Apr 7, 2019
@aklish aklish deleted the feature/datastore-jpa branch April 7, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants