Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple classloaders for CoerceUtil. #693

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

DennisMcWherter
Copy link
Collaborator

Addresses issues with: #689

In summary, BeanUtilsBean#getInstance returns a pseudo-singleton. Namely, it's based on the Thread.currentThread().getContextClassLoader().

This PR sets up CoerceUtil for each new classloader as necessary.

@coveralls
Copy link
Collaborator

coveralls commented Aug 15, 2018

Coverage Status

Coverage increased (+0.05%) to 71.679% when pulling cfe02a9 on multiClassLoader into c421a63 on master.

@DennisMcWherter DennisMcWherter merged commit 52222ba into master Aug 16, 2018
@DennisMcWherter DennisMcWherter deleted the multiClassLoader branch August 16, 2018 13:55
@wcekan
Copy link
Contributor

wcekan commented Aug 17, 2018

@DennisMcWherter Perhaps we should not hold on to a Classloader reference indefinitely. Could you instead stick that into a WeakReference<ClassLoader>?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants