Allow extensible type conversion #430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
clayreimann
force-pushed
the
fix-type-conversion
branch
from
0d93c79
to
39c80c6
Compare
clayreimann
force-pushed
the
fix-type-conversion
branch
from
39c80c6
to
60fc665
Compare
clayreimann
force-pushed
the
fix-type-conversion
branch
from
ae4ff70
to
be71629
Compare
|
How is does this work with Jackson |
|
@clayreimann you're right. We wouldn't want to stomp on two versions of Elide running in the same JVM. Arguably this could be mitigated by simply running 2 JVM's, but for various reasons that could add unnecessary complexity. Is it possible to add the converter directly to the |
|
Update on this? |
|
Ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd love input from @DeathByTape and @aklish. The only sticking point that I see is we handle type conversion from a static function, so if you (for whatever reason) spun up 2 different Elide instances with different conversion sets the last one to be created would stomp on converters.