Fix date coercion for non-long numeric types #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
|
LGTM. Just one question, are we concerned that this also affects floating point numbers? |
|
I think case when someone requests to convert floating point number to date is pretty exotic. |
|
@clayreimann I agree with @Koka. Maybe that's a bridge we should cross when (if) we get to it 👍 |
|
@xiaoyao1991 I've looked at latest travis log for your integration test #320 and I can see that there is no exceptions related to date parsing itself, but some logical errors in other tests: Both failures look like someone is truncating milliseconds on Date fields somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #328 by the simpliest available way