Entity scan on non-existing data model package silences error #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n obtained is empty.
Doom9527
force-pushed
the
issue-3144-fix
branch
2 times, most recently
from
0b1dd9a
to
45d7c4c
Compare
Solved some problems.
Doom9527
force-pushed
the
issue-3144-fix
branch
from
2b6600b
to
1fa638c
Compare
aklish
reviewed
Apr 13, 2024
aklish
reviewed
Apr 13, 2024
aklish
requested changes
Apr 13, 2024
Doom9527
force-pushed
the
issue-3144-fix
branch
from
768fb50
to
05711ba
Compare
|
Yes, I have added screwdriver yaml back and removed github workflows. |
aklish
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3144
Description
This PR primarily addresses the scenario where
Elideis configured with a non-existent data model package. With the updated implementation,Elidenow fails to start gracefully and throws a runtime exception when encountering an invalid data model package during scanning.Motivation and Context
In the
Standaloneor other projects which importElide, thegetAnnotatedClassesof theDefaultClassScannerunder theElideis called to scan the package. I add a judgment on the Set, and throw an exception if it is empty.How Has This Been Tested?
If a non-existent package name is provided, an exception is thrown as expected.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.