Upgrade to httpclient5 #3042
Merged
Upgrade to httpclient5 #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moizarafat
previously approved these changes
Jul 26, 2023
aklish
previously approved these changes
Aug 26, 2023
|
Not sure why this one wasn't merged |
justin-tay
force-pushed
the
httpclient5
branch
from
57338df
to
46f956d
Compare
justin-tay
force-pushed
the
httpclient5
branch
from
46f956d
to
51ec501
Compare
justin-tay
force-pushed
the
httpclient5
branch
from
51ec501
to
8a02f4a
Compare
justin-tay
force-pushed
the
httpclient5
branch
from
8a02f4a
to
8a376a8
Compare
aklish
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade from httpclient4 to httpclient5.
Motivation and Context
Reduce the total number of dependencies as there is a pre-existing transitive dependency on httpclient5 from elide-datastore-aggregation due to calcite.
How Has This Been Tested?
Pre-existing tests continue to pass.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.