Cleanup tests #1856
Merged
Cleanup tests #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcekan
requested review from
moizarafat and
aklish
and removed request for
moizarafat
wcekan
force-pushed
the
cleanup-tests
branch
2 times, most recently
from
4e1f910
to
3dfd234
Compare
wcekan
force-pushed
the
cleanup-tests
branch
from
3dfd234
to
c49fbf7
Compare
aklish
requested changes
Feb 22, 2021
elide-integration-tests/src/test/java/com/yahoo/elide/async/integration/tests/AsyncIT.java
Show resolved
Hide resolved
elide-standalone/src/test/java/example/ElideStandaloneTest.java
Outdated
Show resolved
Hide resolved
wcekan
force-pushed
the
cleanup-tests
branch
2 times, most recently
from
90b249e
to
2a30f12
Compare
wcekan
force-pushed
the
cleanup-tests
branch
from
2a30f12
to
cbbc345
Compare
aklish
requested changes
Feb 23, 2021
| assertEquals(getResult3, expected3); | ||
| assertEquals(getResult5, expected5); | ||
| assertEquals(getResult6, expected5); | ||
| .body(equalTo(expected5)); |
There was a problem hiding this comment.
No, that is how it worked.
assertEquals(getResult5, expected5);
assertEquals(getResult6, expected5);There was a problem hiding this comment.
I assume it is making 2 different requests expecting the same results.
| .contentType(JSONAPI_CONTENT_TYPE) | ||
| .accept(JSONAPI_CONTENT_TYPE) | ||
| .get("/filterExpressionCheckObj/3") | ||
| .then() | ||
| .statusCode(HttpStatus.SC_NOT_FOUND) | ||
| .extract().response().asString(); | ||
| .statusCode(HttpStatus.SC_NOT_FOUND); |
There was a problem hiding this comment.
No, there was no expected4. We could add one?
assertEquals(getResult3, expected3);
assertEquals(getResult5, expected5);
assertEquals(getResult6, expected5);There was a problem hiding this comment.
It would resemble
{
"errors": [
{
"detail": "Unknown identifier 3 for filterExpressionCheckObj"
}
]
}
aklish
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup test syntax for better readability.
Using RestAssured with matchers will generate better debug on failure.
Motivation and Context
Code quality.
How Has This Been Tested?
Unit tests
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.