Elide 5 Agg Store: Multiple time grains #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moizarafat
reviewed
Feb 1, 2021
|
|
||
| /** | ||
| * Time Grain class for Week. | ||
| */ | ||
| public class Week extends Date { | ||
| public class Week extends Time { | ||
|
|
||
| public static final String FORMAT = "yyyy-MM-dd"; |
There was a problem hiding this comment.
This can be removed as its not used.
moizarafat
reviewed
Feb 1, 2021
...tastore-aggregation/src/main/java/com/yahoo/elide/datastores/aggregation/timegrains/Day.java
Show resolved
Hide resolved
added 27 commits
February 3, 2021 15:49
aklish
force-pushed
the
MultipleTimeGrains
branch
from
7202b29
to
e983c6e
Compare
rishi-aga
reviewed
Feb 4, 2021
| @DimensionFormula("<%#trimColumnReferences definition%><%/trimColumnReferences%>") | ||
| <%#ifTypeMatches type "TIME"%> | ||
| public com.yahoo.elide.datastores.aggregation.timegrains.<%#getGrainType grain%><%/getGrainType%> get<%#capitalizeFirstLetter name%> <%/capitalizeFirstLetter%>() { |
There was a problem hiding this comment.
getGrainType method can be removed from HandlebarsHelper.
| @@ -141,6 +142,8 @@ public String getJavaType(Type type) { | |||
| return BIGDECIMAL; | |||
| case MONEY: | |||
| return BIGDECIMAL; | |||
| case TIME: | |||
| return DATE; | |||
There was a problem hiding this comment.
if we return "Time" instead of "Date", we can remove if-else block for dimension type in table.hbs file.
Otherwise this is unused and can be removed.
rishi-aga
previously approved these changes
Feb 4, 2021
moizarafat
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.