Introduce case insensitive equality rsql operator. Default is case sensitive #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chandrasekar-Rajasekar
changed the title
aklish
requested changes
Sep 1, 2020
| @@ -59,6 +60,8 @@ | |||
| private static final String SINGLE_PARAMETER_ONLY = "There can only be a single filter query parameter"; | |||
| private static final String INVALID_QUERY_PARAMETER = "Invalid query parameter: "; | |||
| private static final Pattern TYPED_FILTER_PATTERN = Pattern.compile("filter\\[([^\\]]+)\\]"); | |||
| private static final ComparisonOperator INI = new ComparisonOperator("=ini=", true); | |||
| private static final ComparisonOperator NOT_INI = new ComparisonOperator("=outi=", true); | |||
There was a problem hiding this comment.
Looks good, but we should add all the insensitive operators here as well (PREFIXI, INFIXI, etc)
| return equalityExpression(arguments.get(0), path, values); | ||
| return equalityExpression(arguments.get(0), path, values, true); | ||
| } | ||
| if (op.equals(INI)) { |
There was a problem hiding this comment.
Let's make these else if statements.
| return new NotFilterExpression(equalityExpression(arguments.get(0), path, values)); | ||
| return new NotFilterExpression(equalityExpression(arguments.get(0), path, values, true)); | ||
| } | ||
| if (op.equals(NOT_INI)) { |
There was a problem hiding this comment.
I believe we need to add explicit conditions for INFIXI, PREFIX, etc.
aklish
approved these changes
Sep 1, 2020
aklish
pushed a commit
that referenced
this pull request
Sep 22, 2020
…nsitive (#1519) * introduce case insensitive equality rsql operator. Default is case sensitive * refactoring Co-authored-by: Chandrasekar Rajasekar <[email protected]>
aklish
pushed a commit
that referenced
this pull request
Nov 17, 2020
…nsitive (#1519) * introduce case insensitive equality rsql operator. Default is case sensitive * refactoring Co-authored-by: Chandrasekar Rajasekar <[email protected]>
aklish
pushed a commit
that referenced
this pull request
Dec 11, 2020
…nsitive (#1519) * introduce case insensitive equality rsql operator. Default is case sensitive * refactoring Co-authored-by: Chandrasekar Rajasekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RSQL default operations are made case sensitive. Case Insensitive Equality operators are added.
==and=in=are now Case Sensitive=ini=is the case insensitive equivalent.Usage :
=ini='val'-> IN_INSENSITIVE=ini='*val'-> PREFIX_CASE_INSENSITIVE=ini='*val*'-> INFIX_CASE_INSENSITIVE=ini='val*'-> POSTFIX_CASE_INSENSITIVE=in='val'or=='val'-> IN=in='*val'or=='*val'-> PREFIX=in='*val*'or=='*val*'-> INFIX=in='val*'or=='val*'-> POSTFIXMotivation and Context
Having a default case insensitive filter bypasses the datastore index (if exist) thereby making queries slow. User needs to select whether they want CI or CS filter.
How Has This Been Tested?
Integration test and Unit Test
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.