[README] - Fix the standalone README Java sample #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code isn't valid Java. It has a stray `)` and isn't formatted correctly. Thus fix it.
aklish
approved these changes
Jul 7, 2020
|
Good catch. Thanks for the submission! |
gmckerrell
added a commit
to gmckerrell/elide
that referenced
this pull request
Jul 9, 2020
* Add support for ISO8601 to java.time.Instant serialization/deserialization (yahoo#1417) * add queryParams variant for post(), patch() and delete() * remove trailing spaces * add query request parameters to POST, PATCH and DELETE controllers * Update JsonApiEndpoint.java * shorten line * Create ISO8601InstantSerdes.java (#3) * Update ElideSettingsBuilder.java * Update ISO8601InstantSerdeTest.java * Update ISO8601InstantSerde * Update ISO8601InstantSerdeTest.java * remove trailing whitespace * remove redundant import * try changing class name to avoid travis failure... * Update InstantSerdeTest.java * Update ElideSettingsBuilder.java * Update ElideSettingsBuilder.java * change to jupiter test framework * Rename InstantSerde to InstantSerde.java * auto-register InstantSerde (#5) * switch to using ISO_OFFSET_DATE_TIME to avoid JDK-8 bug * fix typo * fix serialization Co-authored-by: Aaron Klish <[email protected]> * [README] - Fix the standalone README Java sample (yahoo#1415) The old code isn't valid Java. It has a stray `)` and isn't formatted correctly. Thus fix it. Co-authored-by: Aaron Klish <[email protected]> * Bump classgraph from 4.8.86 to 4.8.87 (yahoo#1419) Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.8.86 to 4.8.87. - [Release notes](https://github.com/classgraph/classgraph/releases) - [Commits](classgraph/classgraph@classgraph-4.8.86...classgraph-4.8.87) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Aaron Klish <[email protected]> * Bump spring.boot.version from 2.3.0.RELEASE to 2.3.1.RELEASE (yahoo#1395) Bumps `spring.boot.version` from 2.3.0.RELEASE to 2.3.1.RELEASE. Updates `spring-boot-starter-web` from 2.3.0.RELEASE to 2.3.1.RELEASE - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.3.0.RELEASE...v2.3.1.RELEASE) Updates `spring-boot-starter-data-jpa` from 2.3.0.RELEASE to 2.3.1.RELEASE - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.3.0.RELEASE...v2.3.1.RELEASE) Updates `spring-boot-starter-test` from 2.3.0.RELEASE to 2.3.1.RELEASE - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.3.0.RELEASE...v2.3.1.RELEASE) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Aaron Klish <[email protected]> * Bump postgresql from 42.2.12 to 42.2.14 (yahoo#1392) Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.12 to 42.2.14. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md) - [Commits](pgjdbc/pgjdbc@REL42.2.12...REL42.2.14) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump version.jetty from 9.4.29.v20200521 to 9.4.30.v20200611 (yahoo#1393) Bumps `version.jetty` from 9.4.29.v20200521 to 9.4.30.v20200611. Updates `jetty-server` from 9.4.29.v20200521 to 9.4.30.v20200611 - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.29.v20200521...jetty-9.4.30.v20200611) Updates `jetty-servlet` from 9.4.29.v20200521 to 9.4.30.v20200611 - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.29.v20200521...jetty-9.4.30.v20200611) Updates `jetty-continuation` from 9.4.29.v20200521 to 9.4.30.v20200611 Updates `jetty-webapp` from 9.4.29.v20200521 to 9.4.30.v20200611 - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.29.v20200521...jetty-9.4.30.v20200611) Updates `jetty-servlets` from 9.4.29.v20200521 to 9.4.30.v20200611 - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.29.v20200521...jetty-9.4.30.v20200611) Updates `websocket-server` from 9.4.29.v20200521 to 9.4.30.v20200611 Updates `javax-websocket-server-impl` from 9.4.29.v20200521 to 9.4.30.v20200611 Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Aaron Klish <[email protected]> * Bump build-helper-maven-plugin from 3.1.0 to 3.2.0 (yahoo#1391) Bumps [build-helper-maven-plugin](https://github.com/mojohaus/build-helper-maven-plugin) from 3.1.0 to 3.2.0. - [Release notes](https://github.com/mojohaus/build-helper-maven-plugin/releases) - [Commits](mojohaus/build-helper-maven-plugin@build-helper-maven-plugin-3.1.0...build-helper-maven-plugin-3.2.0) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Aaron Klish <[email protected]> * Issue 683 (yahoo#1384) * Improved error handling * Tests * update test * Added logic to test collections against collections * Added operator in test that traverses to-many relationship * Converted text operators * Added support for comparator operators * Build passes * Added back failing Filter IT test * Updated dialect tests * Updateed FilterIT tests Co-authored-by: wcekan <[email protected]> Co-authored-by: Aaron Klish <[email protected]> Co-authored-by: Aaron Klish <[email protected]> * Update changelog.md Co-authored-by: Aaron Klish <[email protected]> Co-authored-by: David R Soller <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: William Cekan <[email protected]> Co-authored-by: wcekan <[email protected]> Co-authored-by: Aaron Klish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old code isn't valid Java. It has a stray
)and isn't formatted correctly. Thus fix it.Viewing without white space should make things easier
Motivation and Context
It bothered me when reading an otherwise very nice readme.
How Has This Been Tested?
Doesn't have issues when pasted into IntelliJ
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.