Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant fetch join for filters #1326

Merged
merged 2 commits into from
May 16, 2020
Merged

Conversation

aklish
Copy link
Member

@aklish aklish commented May 16, 2020

When Elide fetch joins toOne relationships, it can overlap with a join because of a filter expression resulting in two joins. This complicates the SQL and reduces performance.

How Has This Been Tested?

Updated unit tests.

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@coveralls
Copy link
Collaborator

coveralls commented May 16, 2020

Coverage Status

Coverage increased (+0.02%) to 81.798% when pulling 59c3091 on RemoveRedundantFetchJoin into a14ccfb on master.

Copy link
Contributor

@wcekan wcekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aklish aklish merged commit 227c2dd into master May 16, 2020
@aklish aklish deleted the RemoveRedundantFetchJoin branch May 16, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants