Fixes #2789 (#2880)

* Fixes #2789 * Added space to test build fix * Another test * Another test
yahoo · Feb 11, 2023 · 752c411 · 752c411
1 parent f21f359
commit 752c411
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/elide-core/src/main/java/com/yahoo/elide/core/utils/coerce/converters/Serde.java b/elide-core/src/main/java/com/yahoo/elide/core/utils/coerce/converters/Serde.java
@@ -11,6 +11,7 @@
  * @param <T> The deserialized type
  */
 public interface Serde<S, T> {
+
     /**
      * Deserialize an instance of type S to type T.
      * @param val The thing to deserialize

diff --git a/...oot-autoconfigure/src/main/java/com/yahoo/elide/spring/controllers/JsonApiController.java b/...oot-autoconfigure/src/main/java/com/yahoo/elide/spring/controllers/JsonApiController.java
@@ -146,7 +146,7 @@ public ResponseEntity<String> call() throws Exception {
         };
     }
 
-    @DeleteMapping(value = "/**")
+    @DeleteMapping(value = "/**", produces = JSON_API_CONTENT_TYPE)
     public Callable<ResponseEntity<String>> elideDelete(@RequestHeader HttpHeaders requestHeaders,
                                                         @RequestParam MultiValueMap<String, String> allRequestParams,
                                                         HttpServletRequest request,

diff --git a/elide-spring/elide-spring-boot-autoconfigure/src/test/java/example/tests/ControllerTest.java b/elide-spring/elide-spring-boot-autoconfigure/src/test/java/example/tests/ControllerTest.java
@@ -282,6 +282,18 @@ public void jsonApiDeleteTest() {
                 .statusCode(HttpStatus.SC_NO_CONTENT);
     }
 
+    /**
+     * Function to verify the content type of a HTTP Delete error request.
+     */
+    @Test
+    public void jsonApiDeleteErrorTest() {
+        when()
+                .delete("/json/group/doestnotexist")
+                .then()
+                .contentType(JsonApiController.JSON_API_CONTENT_TYPE)
+                .statusCode(HttpStatus.SC_NOT_FOUND);
+    }
+
     @Test
     @Sql(statements = {
             "INSERT INTO ArtifactProduct (name, commonName, description, group_name) VALUES\n"