Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout attributes were received from the layout but are not valid for the data source counts. Attributes will be ignored. #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WestFR
Copy link

@WestFR WestFR commented Nov 10, 2020

Related to issue #47.

Fixed an error that could appear when updating the list when cells are added or removed.

This error is : 
```
[CollectionView] Layout attributes <CollectionViewSlantedLayout.CollectionViewSlantedLayoutAttributes: 0x7ff1035113c0> index path: (<NSIndexPath: 0xbcd26c36f94746f0> {length = 2, path = 0 - 3}); frame = (0 603; 414 275); zIndex = 3;  were received from the layout <CollectionViewSlantedLayout.CollectionViewSlantedLayout: 0x7ff1035148a0> but are not valid for the data source counts. Attributes will be ignored.
```
🐛 Fix issue when call invalidateLayout()
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #48 (caed6d0) into master (a26e4cc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   94.53%   94.57%   +0.03%     
==========================================
  Files           8        8              
  Lines         256      221      -35     
==========================================
- Hits          242      209      -33     
+ Misses         14       12       -2     
Impacted Files Coverage Δ
Sources/CollectionViewSlantedLayout.swift 97.93% <100.00%> (-0.22%) ⬇️
Sources/Extensions/CAShapeLayer+Helpers.swift 100.00% <0.00%> (ø)
Sources/Internal/CollectionViewSlantedMasks.swift 100.00% <0.00%> (ø)
...es/Extensions/UICollectionViewLayout+Helpers.swift 100.00% <0.00%> (ø)
Sources/CollectionViewSlantedCell.swift 33.33% <0.00%> (+2.56%) ⬆️
...ternal/CollectionViewSlantedLayoutAttributes.swift 81.81% <0.00%> (+3.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26e4cc...caed6d0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant