Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining default_tags only for rails group #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

magec
Copy link

@magec magec commented Aug 28, 2024

Currently, yabeda-rails plugin do not have into account :rails group default_labels when populating metrics. This change allows defining tags for :rails group, so if you are using other yabeda plugins they don't get populated with them.

The main problem here is that we are using yabeda-rails and yabeda-puma in the same application. If we set default_tags, both rails and puma metrics will have that tag populated. If we use the :group option setting it to rails (so the tag is only added to rails metrics), the plugin ignores it. This change makes rails plugin aware of :rails groups metrics.

@magec
Copy link
Author

magec commented Sep 10, 2024

Is there any chance this could get merged @Envek ? asking for a friend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant