fix(stitching): support stitching unions of types with enums

Closes #13.
yaacovCR · Mar 26, 2020 · a28ad00 · a28ad00
1 parent 2adc7b4
commit a28ad00
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 5 deletions.
diff --git a/src/stitching/checkResultAndHandleErrors.ts b/src/stitching/checkResultAndHandleErrors.ts
@@ -2,10 +2,9 @@ import {
   GraphQLResolveInfo,
   responsePathAsArray,
   getNullableType,
-  isObjectType,
+  isCompositeType,
+  isLeafType,
   isListType,
-  isEnumType,
-  isScalarType,
   ExecutionResult,
   GraphQLError,
   GraphQLType,
@@ -60,7 +59,7 @@ export function handleResult(
 
   const nullableType = getNullableType(info.returnType);
 
-  if (isObjectType(nullableType) || isListType(nullableType)) {
+  if (isCompositeType(nullableType) || isListType(nullableType)) {
     annotateWithChildrenErrors(result, errors);
   }
 
@@ -70,7 +69,7 @@ export function handleResult(
 function parseOutputValue(type: GraphQLType, value: any) {
   if (isListType(type)) {
     return value.map((v: any) => parseOutputValue(getNullableType(type.ofType), v));
-  } else if (isEnumType(type) || isScalarType(type)) {
+  } else if (isLeafType(type)) {
     return type.parseValue(value);
   }
   return value;

diff --git a/src/test/testMergeSchemas.ts b/src/test/testMergeSchemas.ts
@@ -130,6 +130,8 @@ let enumTest = `
     numericEnum: NumericEnum
   }
 
+  union UnionWithEnum = EnumWrapper
+
   schema {
     query: Query
   }
@@ -139,6 +141,7 @@ let enumTest = `
     numericEnum: NumericEnum
     listNumericEnum: [NumericEnum]
     wrappedEnum: EnumWrapper
+    unionWithEnum: UnionWithEnum
   }
 `;
 
@@ -153,6 +156,9 @@ enumSchema = makeExecutableSchema({
     NumericEnum: {
       TEST: 1,
     },
+    UnionWithEnum: {
+      __resolveType: () => 'EnumWrapper'
+    },
     Query: {
       color(parent, args) {
         return args.input === '#EA3232' ? args.input : null;
@@ -169,6 +175,12 @@ enumSchema = makeExecutableSchema({
           numericEnum: 1
         };
       },
+      unionWithEnum() {
+        return {
+          color: '#EA3232',
+          numericEnum: 1
+        };
+      },
     },
   },
 });
@@ -643,6 +655,12 @@ testCombinations.forEach(async combination => {
                 color
                 numericEnum
               }
+              unionWithEnum {
+                ... on EnumWrapper {
+                  color
+                  numericEnum
+                }
+              }
             }
           `,
         );
@@ -672,6 +690,12 @@ testCombinations.forEach(async combination => {
                 color
                 numericEnum
               }
+              unionWithEnum {
+                ... on EnumWrapper {
+                  color
+                  numericEnum
+                }
+              }
             }
           `,
         );
@@ -703,6 +727,10 @@ testCombinations.forEach(async combination => {
               color: 'RED',
               numericEnum: 'TEST',
             },
+            unionWithEnum: {
+              color: 'RED',
+              numericEnum: 'TEST',
+            },
           },
         });
         expect(mergedResult).to.deep.equal(enumResult);